Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve save criteria #8999

Closed
Vanessa219 opened this issue Aug 18, 2023 · 0 comments
Closed

Improve save criteria #8999

Vanessa219 opened this issue Aug 18, 2023 · 0 comments
Assignees
Milestone

Comments

@Vanessa219
Copy link
Member

Vanessa219 commented Aug 18, 2023

Following is the behavior which I would prefer for different cases:

  1. query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the name N2 and condition C2 --> we directly save the new query criteria
  2. issues/8913: query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the same name N1 with conditions C2 --> we prompt the user if they would like to overwrite conditions C1 with C2
  3. This issue: query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the name N2 but with same condition C1 --> we prompt the user if they would like to rename query criteria N1 to N2
  4. query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the same name N1 with same conditions C1 --> inform the user that query criteria with same name and conditions already exist
  5. This issue: query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the exist name N2 but with same condition C1 --> we prompt the user

I know this will complicate the logic a bit. But, I feel it will resolve the issue fully.

Thanks

Originally posted by @fenilgmehta in #8813 (comment)

@Vanessa219 Vanessa219 self-assigned this Aug 18, 2023
@Vanessa219 Vanessa219 added this to the 2.10.1 milestone Aug 18, 2023
Vanessa219 added a commit that referenced this issue Aug 18, 2023
@88250 88250 changed the title Improve save criteria Improve save criteria Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants