Skip to content

HTTPS certificate is no longer verified when Convert network images to local images #9080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Geo123abc opened this issue Aug 31, 2023 · 5 comments
Closed
3 tasks done

HTTPS certificate is no longer verified when Convert network images to local images #9080

Geo123abc opened this issue Aug 31, 2023 · 5 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.10.3

Comments

@Geo123abc
Copy link

Geo123abc commented Aug 31, 2023 •
edited by 88250
Loading

文档中不存在网络图片

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

把下面这段markdown粘贴到思源笔记中，然后“网络图片转换为本地图片”--“正在下载网络图片”--“文档中不存在网络图片”，也就是转换失败，我把图片链接粘贴到谷歌浏览器，发现是https不安全之类，是网站证书到期了吗？

人工指定绘图范围。


![](https://hf.icpms.top:33444/uploads/big/f5d470daf471aa56508d87fab9b4e118.png)

Expected result

思源笔记能不能针对这种情况处理一下，允许不安全链接，按道理是可以下载图片的

Screenshot or screen recording presentation

No response

Version environment

- Version: v2.10.2
- Operating System: windows 10
- Browser (if used): 谷歌浏览器

Log file

无

More information

No response
@88250
Copy link
Member

88250 commented Aug 31, 2023

http 也下载不了：

image

@88250 88250 closed this as completed Aug 31, 2023
@Geo123abc
Copy link
Author 

https://hf.icpms.top:33444/uploads/big/f5d470daf471aa56508d87fab9b4e118.png

我这里可以啊

你如果把链接贴到IDM或者迅雷之类的下载器试试

@88250
Copy link
Member

88250 commented Aug 31, 2023

哦，用 https 并忽略证书检查可以访问。

@Geo123abc
Copy link
Author

哦，用 https 并忽略证书检查可以访问。

我不太懂，但是不知道思源笔记能改进一下吗？

PS.这次我已经半自动+手工搞好了，我以后估计也不会再碰到了，只是碰到，所以来提了一下

@88250 88250 self-assigned this Aug 31, 2023
@88250 88250 changed the title 文档中不存在网络图片 HTTPS certificate is no longer verified when Convert network images to local images Aug 31, 2023
@88250 88250 added this to the 2.10.3 milestone Aug 31, 2023
@88250
Copy link
Member

88250 commented Aug 31, 2023

好的，下个版本改进。

88250 added a commit that referenced this issue Aug 31, 2023
@88250
🎨 HTTPS certificate is no longer verified when `Convert network image…

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
2f2d617 
…s to local images` #9080
EightDoor added a commit to EightDoor/siyuan that referenced this issue Sep 1, 2023
@EightDoor
Merge commit 'a63e1fda2e203917ae7f72cb359155f4094c4f3e' into develop
b11fa03 
* commit 'a63e1fda2e203917ae7f72cb359155f4094c4f3e': (217 commits)
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  💄
  ⚡ Improve block loading performance on Windows/Linux/macOS amd64 arch siyuan-note#9084
  🐛 Block hyperlinks do not point to regenerated block IDs when importing .sy.zip siyuan-note#9083
  🎨 Reduce the memory usage of PDF asset file content parsing on the mobile siyuan-note#9079
  🎨 HTTPS certificate is no longer verified when `Convert network images to local images` siyuan-note#9080
  🐛 fix siyuan-note#9076
  🐛 fix siyuan-note#9076
  🐛
  🎨 siyuan-note#9068
  🎨 Improve the response status code of  kernel API `/api/file/getFile` siyuan-note#9075
  Improve the response status code of  kernel API `/api/file/getFile` (siyuan-note#9075)
  ✨ siyuan-note#9032
  ✨ siyuan-note#9032
  🐛 The update button is not displayed after the marketplace package version is updated Fix siyuan-note#9074
  ✨ siyuan-note#9032
  🎨 Improve asset file content search preview escaping siyuan-note#9073
  🎨 Improve asset file content search preview escaping siyuan-note#9073
  🎨 Improve EPUB asset file content parsing siyuan-note#9072
  ♻️ siyuan-note#9032
  ...

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.10.3
Development

No branches or pull requests
2 participants
@88250 @Geo123abc