Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable selecting content on the top bar of the left panel on the iPhone #9096

Closed
STMRabbit opened this issue Sep 2, 2023 · 12 comments
Closed
Assignees
Milestone

Comments

@STMRabbit
Copy link

STMRabbit commented Sep 2, 2023

In what scenarios do you need this feature?

Not supporting long press caused these issues on mobile:

  1. moving icons on panels is not possible on iPad.
  2. "more" menu (right click menu) is hard to touch (because menu button is small on mobile devices)
  3. a useless "text selecting" calling on some elements is useless and disturbing

IMG_0905

For now, long press elements on mobile devices is calling "select text", which doesn't make sense, it should be like:

  1. when long press text editor area: select text
  2. when long press title edit box (not titles in documents tree) : select text
  3. when long press other elements (include titles in documents tree, buttons etc.) : pop out right click menu ("more" menu).

Describe the optimal solution

Maybe long press also should be supported on desktop app as well, considering there are desktop devices which support touch screen like Microsoft Surface or Pinetab. But I don't have those devices, so I can't give a clear suggestion.

Describe the candidate solution

At least disable long press calling on non-editor elements because that feature is useless and even disturbing.

Other information

mobile note taking app with same tec stack (for reference)
joplin
obsidian

@Vanessa219 Vanessa219 mentioned this issue Sep 4, 2023
15 tasks
@Vanessa219
Copy link
Member

  1. iPad issue: Problems on iPad #4238
  2. What function does the "More" menu (right-click menu) refer to?
  3. Disable select left top bar will avoid this issue

There is no context menu on the iPhone, so we will disable the select event

@Vanessa219 Vanessa219 changed the title Long press support on mobile app (iPad/iPhone/android) like obsidian does Disable select left top bar on the iPhone Sep 4, 2023
@Vanessa219 Vanessa219 self-assigned this Sep 4, 2023
@Vanessa219 Vanessa219 added this to the 2.10.3 milestone Sep 4, 2023
Vanessa219 added a commit that referenced this issue Sep 4, 2023
@STMRabbit
Copy link
Author

STMRabbit commented Sep 4, 2023

Hello, thanks for fixing that! And here are the answers referring to your question:

I

iPad issue: #4238

i apologize for my expressing, but what I was referring is the issue that: I can't move these buttons (shows in the image below) on iPad, because moving these buttons need to right-click the mouse to call the context menu, which iPad doesn't usually have.

image

and i was just saying maybe long press to call the context menu (AKA "more" menu or "right-click" menu is a designing option)

II

What function does the "More" menu (right-click menu) refer to?

i meant this button:

image

on iOS / iPad and android, when long press a note or notebook in doc tree, it pops out text selecting cursor which doesn't make sense, it should be equal to when you press the "menu" button, because it doesn't make sense to select text at that field (maybe you already fixed it in last commit?).
in another word: for iPhone/ iPad/ android, long press a note or notebook in doc tree should pop out the context menu (AKA "more" menu or "right-click" menu) , instead of calling text-selecting cursor.

thank you again!

@STMRabbit
Copy link
Author

for the question 2, it's a vid that how obsidian does when long press a note.

RPReplay_Final1693837041.mov

@STMRabbit
Copy link
Author

oh and sorry I found another issue that I can't seem to delete a workspace on iPad once it's created.

@88250 88250 changed the title Disable select left top bar on the iPhone Disable selecting content on the top bar of the left panel on the iPhone Sep 5, 2023
@Vanessa219
Copy link
Member

@STMRabbit
Copy link
Author

thank you again!

I

Right-click can not open the menu on the dock icon

yes thank you! and just to be more clear, what I meant is that since iPad doesn't have a mouse, so all the operate which need right-clicking the mouse, is not able to do on iPad.

II

Long press the file tree item to open the right menu on the mobile

yes, indeed, thank you so much!

III

Open about -> workspace -> open -> click select element

i apologize for my misunderstood, is this a TODO or an instruction? cuz if it's an instruction, i can't find any element/button related to " workspace" or similar thing in about page. And if it's a TODO, do you need me to open another issue to describe it?

Thank you!

@Vanessa219
Copy link
Member

Sorry, I was talking about mobile, if it's an iPad, try this:

image

@STMRabbit
Copy link
Author

STMRabbit commented Sep 5, 2023

yes, thank you for your helping! but it seems as i said, that button in your screenshot can't delete a profile/workspace either. On iPad i can only remove a workspace/profile from the list by touch the "X" icon, the entire workspace/profile hadn't been deleted, still exist, because I can open it later again by "open" button even after I removed it.

Also as you mentioned, i tested the iPhone client too, and it turns out I can't completely delete a workspace on iPhone either. (the "-" button just remove it from list, too, because after i removed it i can still open again with "open" button)

on android, i can delete a workspace using root permission + file manager, but can't delete it within siyuan app itself.

sorry if it's just because i didn't find it, but it's at least not that obvious.

@Vanessa219
Copy link
Member

It used to be physically deleted, but some users often deleted it by mistake, so it was later changed to remove it from the workspace list.

@STMRabbit
Copy link
Author

Thank you for your answer! Maybe it's a nice design, however personally I think it's also important to be able to physically delete a workspace (maybe it could be located deeply in settings or something to prevent accident), since on iOS devices, the user can't really use file manager to manage files.
But don't worry, it's just a suggestion, user can still uninstall siyuan and install again for that purpose, if you believe it's better.

@88250
Copy link
Member

88250 commented Sep 8, 2023

@STMRabbit We will implement it in the next version, thanks #9134

@STMRabbit
Copy link
Author

Thank you so much for the quick fix! In case I expressed myself incorrectly last time, the term "uninstall SiYuan and install it again" was meant to describe the procedure for clearing data. It's not intended as a threat, like "if you don't implement it, the user will uninstall and leave." :)
I love SiYuan; it's the best app I've ever used. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants