Skip to content

Remove the global read-only mode toggle button on the top bar #9145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
88250 opened this issue Sep 9, 2023 · 14 comments
Closed

Remove the global read-only mode toggle button on the top bar #9145

88250 opened this issue Sep 9, 2023 · 14 comments
Assignees
Milestone

Comments

@88250
Copy link
Member

88250 commented Sep 9, 2023

#8417 A single document read-only mode has been added. In order to maintain the consistency of functional design, the global read-only mode button needs to be removed from the top bar.

If you need to change the global read-only status, you can set it in Settings - Editor - Read-only mode, or use shortcut keys.

@88250 88250 added this to the 2.10.5 milestone Sep 9, 2023
@88250
Copy link
Member Author

88250 commented Sep 9, 2023

Fixed in 2659052

@tcmtom
Copy link

tcmtom commented Sep 9, 2023

我看单篇的只读的开关放在文档里面了,在全局上留一个也不矛盾吧,或者开发一个全局按钮布局的调整功能

@88250
Copy link
Member Author

88250 commented Sep 9, 2023

全局也放的话状态会有冲突,比如全局是只读,而文档是允许编辑,此时全局这个按钮是应该显示只读还是编辑呢?这样会给用户造成困扰。要调整全局只读模式的话建议用快捷键。

@tcmtom
Copy link

tcmtom commented Sep 9, 2023

这个逻辑设置和插件总开关类似就好了,总的高于单篇的。

@88250
Copy link
Member Author

88250 commented Sep 9, 2023

逻辑上是单篇配置覆盖全局配置,如果有全局按钮,那么这个全局按钮就没法展现了,会给用户造成困扰的。

@tcmtom
Copy link

tcmtom commented Sep 9, 2023

总的图标显现只通过点击和快捷键来控制。
当总的处于编辑状态时,单篇可以是编辑状态也可以是只读状态;
当总的处于只读状态时,单篇均为只读。

@88250
Copy link
Member Author

88250 commented Sep 9, 2023

全局只读时,全局按钮图标到底是显示编辑还是只读?

我们之前也考虑过,因为加了单篇只读后就会出现冲突引起歧义,所以移除是更合理的。其实类似 Notion 的产品设计是没有全局只读的,只有单篇只读,有一种可能是全局只读对于用户来说场景不多,单篇只读的场景更为常见。

另外,全局只读按钮如果实在需要,应该是能通过插件实现的,期待一下吧,原生就不考虑了,会给用户带来困扰的。

@tcmtom
Copy link

tcmtom commented Sep 9, 2023

OK,等下周推出新版本了看看大家的反应再说

@tcmtom
Copy link

tcmtom commented Sep 11, 2023

还有个事儿就是,因为大家可能喜欢只在手机端看,如果移除了这个按钮,手机端又没有快捷键可以用的话,那可能对手机端用户来说不太友好

@88250
Copy link
Member Author

88250 commented Sep 11, 2023

@tcmtom 总的只读只能设置里面调整,单篇的面包屑有按钮,对手机端使用影响不大。

@chenshinshi
Copy link

想提个有关“默认”用词的问题:现在的只读模式默认是预设/默认,用户选择了启用后,关闭会优先选禁用而不是默认,估计也不太理解默认是什么意思,也许改成跟随全局设置或者加个提示会好一些?

@chenshinshi
Copy link

全局按钮图标我觉得是表示全局只读和全局编辑,现在是面包屑上一个锁,顶栏上的图标我觉得不会引起歧义,主要是更方便,由插件实现也担心思源卡顿。

@88250
Copy link
Member Author

88250 commented Sep 11, 2023 via email

@88250
Copy link
Member Author

88250 commented Sep 11, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants