Skip to content

Support for symlinked theme folder when exporting HTML #9173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdzz2048 opened this issue Sep 12, 2023 · 0 comments
Closed

Support for symlinked theme folder when exporting HTML #9173

mdzz2048 opened this issue Sep 12, 2023 · 0 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.10.6

Comments

@mdzz2048
Copy link
Contributor

mdzz2048 commented Sep 12, 2023 •
edited by 88250
Loading

导出 HTML 支持使用软链接的主题

In what scenarios do you need this feature?

平时会使用多个工作空间，我把自己的主题用软链接链接到了这些工作空间里。今天发现在导出 Word 的时候会报下面这个错误。

E 2023/09/12 22:46:06 export.go:531: copy appearance from [D:\SiYuan\Test\conf\appearance\themes\Lite] to [C:\Users\xxx\Downloads\2023-09-12] failed: read D:\SiYuan\Test\conf\appearance\themes\Lite: Incorrect function.

我看源码这里是使用拼接的路径，不能写入软链接的实际目录。能否考虑支持一下这种特殊的使用情况？

siyuan/kernel/model/export.go

Lines 527 to 534 in 38bb738

for _, src := range srcs {
from := filepath.Join(util.AppearancePath, src)
to := filepath.Join(savePath, "appearance", src)
if err := filelock.Copy(from, to); nil != err {
logging.LogErrorf("copy appearance from [%s] to [%s] failed: %s", from, savePath, err)
return
}
}

Describe the optimal solution

支持主题使用软链接

Describe the candidate solution

No response

Other information

No response
@88250 88250 changed the title pandoc 导出支持使用软链接的主题 Support for symlinked theme folder when exporting HTML Sep 13, 2023
@88250 88250 self-assigned this Sep 13, 2023
@88250 88250 added this to the 2.10.6 milestone Sep 13, 2023
88250 added a commit that referenced this issue Sep 13, 2023
@88250
🎨 Support for symlinked theme folder when exporting HTML #9173

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
736256e
@88250 88250 closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.10.6
Development

No branches or pull requests
2 participants
@88250 @mdzz2048