Skip to content

Supports ⌃⌥⇧⌘, ⌃⌥⌘, ⌃⇧⌘ hotkeys on macOS #9220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
LoneFireBlossom opened this issue Sep 18, 2023 · 0 comments
Closed
3 tasks done

Supports ⌃⌥⇧⌘, ⌃⌥⌘, ⌃⇧⌘ hotkeys on macOS #9220

LoneFireBlossom opened this issue Sep 18, 2023 · 0 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.10.15

Comments

@LoneFireBlossom
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

Ctrl+CMD+其它按钮的快捷键在思源里无法被分配。
就是这样的：
image

例如，在设置-快捷键里按Ctrl+CMD+X，快捷键会被认成是X。

Expected result

Screenshot or screen recording presentation

CleanShot 2023-09-18 at 18 52 17

Version environment

- Version: 2.10.5
- Operating System: macOS 13.5.2
- Browser (if used):

Log file

这日志……有用吗？我就几分钟前按的快捷键按钮所以就复制了最后一部分。

I 2023/09/18 18:23:37 box.go:79: auto stat [trees=72, blocks=2686, dataSize=5.6 MB, assetsSize=4.3 MB]
I 2023/09/18 18:23:37 disk.go:33: disk usage [total=4.0 TB, used=1.5 TB, free=2.5 TB]
E 2023/09/18 18:40:47 logging.go:159: PANIC RECOVERED: runtime error: invalid memory address or nil pointer dereference
	/usr/local/go/src/runtime/panic.go:884 (0x1000372b2)
/usr/local/go/src/runtime/panic.go:260 (0x10004ebbc)
/usr/local/go/src/runtime/signal_unix.go:841 (0x10004eb8c)
/Users/Vanessa/Work/Code/siyuan/kernel/model/tag.go:288 (0x10165ff2e)
/Users/Vanessa/Work/Code/siyuan/kernel/model/tag.go:260 (0x10165f904)
/Users/Vanessa/Work/Code/siyuan/kernel/api/search.go:118 (0x1016e2306)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x101653907)
/Users/Vanessa/Work/Code/siyuan/kernel/model/session.go:163 (0x1016529c2)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x100c92d59)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-contrib/sessions@v0.0.5/sessions.go:54 (0x100c92d45)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x101699f21)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-contrib/gzip@v0.0.6/handler.go:60 (0x101699ef9)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x1016fa29b)
/Users/Vanessa/Work/Code/siyuan/kernel/server/serve.go:537 (0x1016fa287)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x101653d0a)
/Users/Vanessa/Work/Code/siyuan/kernel/model/session.go:292 (0x101653cf4)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x101653c44)
/Users/Vanessa/Work/Code/siyuan/kernel/model/session.go:265 (0x1016539d8)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/context.go:174 (0x100a5b34a)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/gin.go:620 (0x100a5afd1)
/Users/Vanessa/Work/GoGoGo/pkg/mod/github.com/gin-gonic/gin@v1.9.1/gin.go:576 (0x100a5aafc)
/usr/local/go/src/net/http/server.go:2936 (0x100330a95)
/usr/local/go/src/net/http/server.go:1995 (0x10032bfb1)
/usr/local/go/src/runtime/asm_amd64.s:1598 (0x10006e860)

More information

No response
@Vanessa219 Vanessa219 added this to the 2.10.15 milestone Nov 12, 2023
Vanessa219 added a commit that referenced this issue Nov 12, 2023
@Vanessa219
🎨 fix #9220
4f263b3
@Vanessa219 Vanessa219 changed the title Ctrl+CMD+X hotkey can't be assigned Supports ⌃⌥⇧⌘, ⌃⌥⌘, ⌃⇧⌘ hotkeys on the Mac Nov 12, 2023
@88250 88250 changed the title Supports ⌃⌥⇧⌘, ⌃⌥⌘, ⌃⇧⌘ hotkeys on the Mac Supports ⌃⌥⇧⌘, ⌃⌥⌘, ⌃⇧⌘ hotkeys on macOS Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.10.15
Development

No branches or pull requests
2 participants
@Vanessa219 @LoneFireBlossom