Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try catch plugin onunload #9240

Closed
3 tasks done
WingDr opened this issue Sep 20, 2023 · 3 comments
Closed
3 tasks done

Try catch plugin onunload #9240

WingDr opened this issue Sep 20, 2023 · 3 comments
Assignees
Milestone

Comments

@WingDr
Copy link

WingDr commented Sep 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

起因是小窗无法关闭的问题,后来检查到是因为列表预览插件的onunload报错了导致之后都进行不下去

e11c2c57f9e478fa406c4e3208efa85f

这个显然是默认的onunload,也就是说所有覆写了i18n的插件都会有这个错误导致无法关闭

Expected result

建议把插件里面非必要的默认函数都设置成空的,不然之后很有可能还会有其它乱七八糟的报错,主要是i18n里面不一定会留默认的那些东西

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.10.6
- Operating System: windows 
- Browser (if used):

Log file

image

More information

No response

@Vanessa219
Copy link
Member

我这里重现不了,检查了下这个多语言是存在的。具体是要怎么操作可以重现呢?

@Vanessa219 Vanessa219 removed their assignment Sep 26, 2023
@WingDr
Copy link
Author

WingDr commented Sep 26, 2023

我这里重现不了,检查了下这个多语言是存在的。具体是要怎么操作可以重现呢?

最简单的就是开启那个"预览折叠列表"插件(siyuan-plugin-fold-list-preview),我截图里的错误就是开这个插件出来的

@Vanessa219
Copy link
Member

可以重现了,下个版本加强下容错性,多谢。

Vanessa219 added a commit that referenced this issue Sep 27, 2023
@Vanessa219 Vanessa219 changed the title onunload存在默认操作使得窗口无法关闭 try catch plugin onunload Sep 27, 2023
@Vanessa219 Vanessa219 self-assigned this Sep 27, 2023
@Vanessa219 Vanessa219 added this to the 2.10.8 milestone Sep 27, 2023
@88250 88250 changed the title try catch plugin onunload Try catch plugin onunload Sep 29, 2023
@88250 88250 changed the title Try catch plugin onunload Try catch plugin onunload Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants