Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error tip when renaming tags/bookmarks containing Markdown markers #9248

Closed
3 tasks done
LoneFireBlossom opened this issue Sep 21, 2023 · 8 comments
Closed
3 tasks done

Improve error tip when renaming tags/bookmarks containing Markdown markers #9248

LoneFireBlossom opened this issue Sep 21, 2023 · 8 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.10.8

Comments

@LoneFireBlossom
Copy link

LoneFireBlossom commented Sep 21, 2023 •
edited by 88250

标签"请勿包含Markdown语法标记符"

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

#test/test & abc#可以在文档里正常打出来作为一个标签，并被软件识别。
但是在标签栏-菜单-编辑里打开编辑窗口，什么也不干点确定，会出现如下提示：

image

Expected result

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.10.6
- Operating System: macOS 13.5.2
- Browser (if used):

Log file

More information

思源打算允许#test/test & abc#这种情况吗？目前是哪个字符造成的提示，打算之后禁止吗，我好提前修改一下
@88250
Copy link
Member

88250 commented Sep 21, 2023

& 符号，暂时不会做调整了，先避免使用吧。

@88250 88250 closed this as completed Sep 21, 2023
@LoneFireBlossom
Copy link
Author

LoneFireBlossom commented Sep 21, 2023 •
edited

搜了一下没找到“markdown语法标记符”有哪些，试了试-可以用，emoji也可以用，开发者能说一下还有哪些不能用么

@88250
Copy link
Member

88250 commented Sep 21, 2023

看下这个文件 https://github.com/siyuan-note/siyuan/blob/master/kernel/treenode/marker.go

@LoneFireBlossom
Copy link
Author

& 符号，暂时不会做调整了，先避免使用吧。

我不清楚开发者关闭issue的原因，这个问题迟早是要改的，有没有记录下来（等打算改的时候再reopen）？
现阶段没时间改，可以至少在说明文档-标签里添加「标签不能用哪些符号」的说明啊。

@88250
Copy link
Member

88250 commented Sep 28, 2023

技术上改不了的，不然也不会有这个判断了。

帮助文档增加说明是个好主意，等有空就改进一下，感谢反馈。

@88250 88250 self-assigned this Sep 28, 2023
@88250 88250 changed the title 标签"请勿包含Markdown语法标记符" Improve error reporting text for tags/bookmarks containing Markdown markers Sep 28, 2023
@88250 88250 added this to the 2.10.8 milestone Sep 28, 2023
@88250
Copy link
Member

88250 commented Sep 28, 2023

看了下代码，还是直接在报错文案上明确提示不可用字符好一些，下个版本就改进。

@88250 88250 reopened this Sep 28, 2023
@88250 88250 changed the title Improve error reporting text for tags/bookmarks containing Markdown markers Improve error tip when renaming tags/bookmarks containing Markdown markers Sep 28, 2023
88250 added a commit that referenced this issue Sep 28, 2023
@88250
🎨 Improve error tip when renaming tags/bookmarks containing Markdown …
4283f73 
…markers Fix #9248
@88250 88250 closed this as completed Sep 28, 2023
@LoneFireBlossom
Copy link
Author

看了下代码，还是直接在报错文案上明确提示不可用字符好一些，下个版本就改进。

这解决不了正文里输入的问题啊，起码得输入#A & B#后软件不认这是个标签不会自动变成标签的样子。
如果难以实现就得先得在说明文档里说一下标签里有哪些不能用的字符

@88250
Copy link
Member

88250 commented Sep 28, 2023

好的，还是说明一下吧。

88250 added a commit that referenced this issue Sep 28, 2023
@88250
🎨 Improve error tip when renaming tags/bookmarks containing Markdown …
3ecebb2 
…markers Fix #9248
88250 added a commit that referenced this issue Sep 28, 2023
@88250
🎨 Improve error tip when renaming tags/bookmarks containing Markdown …
8a7c64c 
…markers Fix #9248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.10.8
Development

No branches or pull requests
2 participants
@88250 @LoneFireBlossom