Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the display of line numbers of code blocks with paging in PDF export #9471

Closed
3 tasks done
dream-tentacle opened this issue Oct 21, 2023 · 3 comments
Closed
3 tasks done

Improve the display of line numbers of code blocks with paging in PDF export #9471

dream-tentacle opened this issue Oct 21, 2023 · 3 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.10.13

Comments

@dream-tentacle
Copy link

dream-tentacle commented Oct 21, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

When extracting a PDF file, if there is a code block which is cut into two pages, the line numbers are a mess.
image

Expected result

make sure the line numbers are correct

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.10.11
- Operating System: Windows 11

Log file

No need I think

More information

No response
@dream-tentacle dream-tentacle changed the title Please enter the title of the bug report The code block's line numbers are a mess in PDF file Oct 21, 2023
@88250
Copy link
Member

88250 commented Oct 21, 2023 •
edited

If convenient, please provide code blocks or export .sy.zip for uploading for testing, thank you.

Ref: https://ld246.com/article/1697600947047

@dream-tentacle
Copy link
Author

第十一周.sy.zip

If convenient, please provide code blocks or export .sy.zip for uploading for testing, thank you.

Ref: https://ld246.com/article/1697600947047

@88250 88250 changed the title The code block's line numbers are a mess in PDF file Improve PDF export code block line number display Oct 22, 2023
Vanessa219 added a commit that referenced this issue Oct 24, 2023
@Vanessa219
🎨 fix #9471
91e81ce
@Vanessa219 Vanessa219 added this to the 2.10.13 milestone Oct 24, 2023
Vanessa219 added a commit that referenced this issue Oct 24, 2023
@Vanessa219
🎨 #9471
1a3d67f
@Vanessa219 Vanessa219 removed this from the 2.10.13 milestone Oct 24, 2023
@Vanessa219
Copy link
Member

Vanessa219 commented Oct 24, 2023 •
edited

又优化了下，还麻烦下个版本看看。如果行数过多的话 ，Chrome 导出存在分页时也会有同样的问题，估计只能移除行号再导出了。

Vanessa219 added a commit that referenced this issue Oct 24, 2023
@Vanessa219
🎨 #9471
777c844
Vanessa219 added a commit that referenced this issue Oct 24, 2023
@Vanessa219
🎨 #9471
48f2e80
@Vanessa219 Vanessa219 added this to the 2.10.13 milestone Oct 24, 2023
@Vanessa219 Vanessa219 changed the title Improve PDF export code block line number display Improved the display of line numbers of code blocks with paging in PDF export Oct 24, 2023
@88250 88250 changed the title Improved the display of line numbers of code blocks with paging in PDF export Improve the display of line numbers of code blocks with paging in PDF export Oct 30, 2023
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Oct 31, 2023
@Vanessa219
🎨 fix siyuan-note/siyuan#9471
282ee58
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Oct 31, 2023
@Vanessa219
🎨 siyuan-note/siyuan#9471
76d15e2
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Oct 31, 2023
@Vanessa219
🎨 siyuan-note/siyuan#9471
03cf9de
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Oct 31, 2023
@Vanessa219
🎨 siyuan-note/siyuan#9471
5f05401
@Vanessa219 Vanessa219 mentioned this issue Nov 7, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.10.13
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @dream-tentacle