Skip to content

Flashcard Open in New Tab retains its status #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
chenshinshi opened this issue Oct 31, 2023 · 9 comments
Closed
3 tasks done

Flashcard Open in New Tab retains its status #9561

chenshinshi opened this issue Oct 31, 2023 · 9 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.10.14

Comments

@chenshinshi
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

现在的话变更窗口会刷新页面稍微有点反直觉

Expected result

希望能不刷新页面

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.10.13dev4
- Operating System: win
- Browser (if used):

Log file

无需

More information

No response
@Vanessa219 Vanessa219 self-assigned this Oct 31, 2023
@Vanessa219 Vanessa219 added this to the 2.10.14 milestone Oct 31, 2023
Vanessa219 added a commit that referenced this issue Oct 31, 2023
@Vanessa219
🎨 fix #9561
12f20e7
@Vanessa219 Vanessa219 changed the title 闪卡复习时切换为新窗口或页签打开，可以不刷新页面 Flashcard "Open in New Tab" retains its status Oct 31, 2023
@Vanessa219 Vanessa219 changed the title Flashcard "Open in New Tab" retains its status Flashcard Open in New Tab retains its status Oct 31, 2023
@chenshinshi
Copy link
Author

omg这个bug修了后，我在新页签复习了一部分闪卡然后中途关闭软件（同步正常），又要从头复习@Vanessa219

@chenshinshi
Copy link
Author

以前的话是即便不通过关闭新页签和新窗口重新打开闪卡，通过关闭软件重启打开闪卡都会正常记录闪卡复习进度，现在就是关闭软件无法记录复习进度，只能关闭闪卡界面才能记录。

11.4.mp4

@chenshinshi
Copy link
Author

啊等下，进度记录了，重启软件后虽然页签没有刷新，但是关闭页签重新打开后可以看到闪卡数量变少了。所以问题是出在窗口没有刷新。

@luo-chuan
Copy link

所以还是要刷新？改回来？

@chenshinshi
Copy link
Author

所以还是要刷新？改回来？

不知道能不能加个判断。

@chenshinshi
Copy link
Author

所以还是要刷新？改回来？

螚识别关闭软件为关闭窗口就行，然后触发一次刷新

@chenshinshi
Copy link
Author

刚才又观察到一个怪bug但没有录屏也不太清楚具体细节，新页签复习状态下，用户没有任何操作，突然右上角的闪卡数量增加，卡片界面白屏（就是没有显示任何字和按钮）。

@chenshinshi
Copy link
Author

chenshinshi commented Nov 5, 2023 •
edited
Loading

补个可能有关联的社区bug

https://ld246.com/article/1699167681820

@Vanessa219
Copy link
Member

刚才又观察到一个怪bug但没有录屏也不太清楚具体细节，新页签复习状态下，用户没有任何操作，突然右上角的闪卡数量增加，卡片界面白屏（就是没有显示任何字和按钮）。

这个很奇怪，无法重现。但 #9589 下个版本修复。

至于数据保持那就仅在转换为页签的时候记录一下，后续不进行保持。

Vanessa219 added a commit that referenced this issue Nov 6, 2023
@Vanessa219
🎨 fix #9561 (comment)
b6b1843
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Nov 13, 2023
@Vanessa219 @appdev
🎨 fix siyuan-note/siyuan#9561
abcbeef
appdev pushed a commit to appdev/siyuan-unlock that referenced this issue Nov 13, 2023
@Vanessa219 @appdev
🎨 fix siyuan-note/siyuan#9561 (comment)
be887b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.10.14
Development

No branches or pull requests
3 participants
@Vanessa219 @luo-chuan @chenshinshi