Skip to content

Convert network images/assets to local supports URL-encoded local file names #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kylehz opened this issue Dec 19, 2023 · 11 comments
Closed
3 tasks done

Convert network images/assets to local supports URL-encoded local file names #9929

kylehz opened this issue Dec 19, 2023 · 11 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.11.4

Comments

@kylehz
Copy link

kylehz commented Dec 19, 2023 •
edited by 88250
Loading

网络图片转换为本地图片BUG

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

文字和图片是从sublimetext的markdown preview中复制过来的
点击下网络图片转换为本地图片时，无法下载file://开头的问题，提示：该文档中不存在网络文件

SCR-20231219-rqaz SCR-20231219-rpzg

Expected result

希望能复制图片到思源内部的本地图片目录中

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.11.3
- Operating System:  MacOS BigSur
- Browser (if used):

Log file

无

More information

No response
@88250
Copy link
Member

88250 commented Dec 19, 2023

麻烦制作一个可重现问题的最小数据集上传以便测试，谢谢。

@88250
Copy link
Member

88250 commented Dec 19, 2023

image

这个路径上的文件名是编码后的还是？

@88250 88250 changed the title 网络图片转换为本地图片BUG Convert network images to local supports URL-encoded local file names Dec 19, 2023
@88250 88250 self-assigned this Dec 19, 2023
@88250 88250 added this to the 2.11.4 milestone Dec 19, 2023
88250 added a commit that referenced this issue Dec 19, 2023
@88250
🎨 Convert network images to local supports URL-encoded local file n…

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
6e0524b 
…ames #9929
88250 added a commit that referenced this issue Dec 19, 2023
@88250
🎨 Convert network images to local supports URL-encoded local file n…
c4faf7c 
…ames #9929
@88250 88250 closed this as completed Dec 19, 2023
@88250
Copy link
Member

88250 commented Dec 19, 2023

我们对 URL 编码的文件名进行了一定支持，请等新版本发布后帮忙测试，谢谢。

@kylehz
Copy link
Author

kylehz commented Dec 20, 2023

file:///Users/bigsu/Downloads/siyuantest/%E4%B8%AD%E6%96%87/2.png
路径是url编码的
siyuantest.zip

@88250
Copy link
Member

88250 commented Dec 20, 2023

好的，我这里测试正常了（昨晚发布的 dev），谢谢。

@kylehz
Copy link
Author

kylehz commented Dec 20, 2023 •
edited
Loading

我测试了dev2

1、点【网络图片转换为本地图片】测试正常了，点【网络资源文件转换本地】这个按钮还是报文档中不存在网络文件
image
image

2、还有就是从sublimetext的markdown preview复制过来的时候图片路径没有file://前缀，希望把这个图片直接复制到思源本地文件
image
image

siyuantest.zip

@88250
Copy link
Member

88250 commented Dec 20, 2023

  1. 收到，稍后再改一下转换资源文件
  2. 这样复制的话只能做到复制地址

@kylehz
Copy link
Author

kylehz commented Dec 20, 2023

  1. 收到，稍后再改一下转换资源文件
  2. 这样复制的话只能做到复制地址

问题2还是中文路径的问题，我试了英文路径是可以直接复制到思源本地文件的

@88250
Copy link
Member

88250 commented Dec 20, 2023

好的，稍后我确认下，谢谢。

@88250 88250 changed the title Convert network images to local supports URL-encoded local file names Convert network images/assets to local supports URL-encoded local file names Dec 20, 2023
88250 added a commit that referenced this issue Dec 20, 2023
@88250
🎨 Convert network images/assets to local supports URL-encoded local…
2d06136 
… file names #9929
88250 added a commit that referenced this issue Dec 20, 2023
@88250
🎨 Convert network images/assets to local supports URL-encoded local…
be18e6c 
… file names #9929
@88250
Copy link
Member

88250 commented Dec 20, 2023

已经确认这两个改进可以完成，请等下个 dev 版发布再帮忙测试看看，谢谢。

@kylehz
Copy link
Author

kylehz commented Dec 21, 2023

已经确认这两个改进可以完成，请等下个 dev 版发布再帮忙测试看看，谢谢。

dev3已经测试了没有问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.11.4
Development

No branches or pull requests
2 participants
@88250 @kylehz