Skip to content

Set plugin.name to read-only #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
2234839 opened this issue Dec 21, 2023 · 3 comments
Closed
3 tasks done

Set plugin.name to read-only #9943

2234839 opened this issue Dec 21, 2023 · 3 comments
Assignees
@Vanessa219
Labels
Development
Milestone
2.11.4

Comments

@2234839
Copy link
Member

2234839 commented Dec 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

如题

Expected result

关闭插件后应该卸载掉它注册的命令。
现在只能靠重启

Screenshot or screen recording presentation

No response

Version environment

- Version: v2.11.3
- Operating System: windows
- Browser (if used):

Log file

无

More information

No response
@Vanessa219
Copy link
Member

如下操作是可以移除的，麻烦说一下重现的操作步骤。

QQ20231221-115902-HD.mp4

@2234839
Copy link
Member Author

2234839 commented Dec 21, 2023

会和我的实现有关系吗
https://github.com/2234839/feed_siyuan_plugin/blob/91b9c439f701a15802469a26aa47575516670bc1/src/index.ts#L69C1-L76C8

因为没有找到注销的命令，在 unload 中我尝试了
https://github.com/2234839/feed_siyuan_plugin/blob/91b9c439f701a15802469a26aa47575516670bc1/src/index.ts#L81C1-L81C24
但没有用

default.webm

@Vanessa219
Copy link
Member

name 是唯一标识，只能读，不可修改，稍后我改一下。

@Vanessa219 Vanessa219 changed the title 插件关闭后注册的命令还在 Set plugin.name to read-only Dec 21, 2023
Vanessa219 added a commit that referenced this issue Dec 21, 2023
@Vanessa219
🎨 fix #9943
1d0d7cb
@Vanessa219 Vanessa219 self-assigned this Dec 21, 2023
@Vanessa219 Vanessa219 added this to the 2.11.4 milestone Dec 21, 2023
Vanessa219 added a commit that referenced this issue Dec 26, 2023
@Vanessa219
🎨 #9943
2232cec
@Zuoqiu-Yingyi Zuoqiu-Yingyi mentioned this issue Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Development
Projects
None yet
Milestone
2.11.4
Development

No branches or pull requests
2 participants
@Vanessa219 @2234839