Skip to content

If there are no search results in non-keyword search mode, no longer be prompted to create #9950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choyy opened this issue Dec 21, 2023 · 7 comments
Assignees
Milestone

Comments

@choyy
Copy link

choyy commented Dec 21, 2023

搜索面板中SQL搜索改进

In what scenarios do you need this feature?

使用SQL搜索时

Describe the optimal solution

  1. 当SQL搜索结果为空时,不要显示新建文档 select * from...,可以显示些其他内容,如没有符合条件的内容块
  2. 目前SQL搜索时没有关键词高亮,希望加上关键词高亮,可以只处理最简单的关键词情形content like "%xxx%",这种情形可以覆盖大多数搜索场景了

Describe the candidate solution

No response

Other information

No response

@88250
Copy link
Member

88250 commented Dec 22, 2023

  1. 我们考虑了下,在搜索方式为非 关键字 时如果没有搜索结果,则都不显示创建
  2. 暂时不做调整

感谢反馈。

@88250 88250 added this to the 2.11.4 milestone Dec 22, 2023
@88250 88250 changed the title 搜索面板中SQL搜索改进 If there are no search results in non-keyword search mode, no longer be prompted to create Dec 22, 2023
@choyy
Copy link
Author

choyy commented Dec 22, 2023

  1. 能改一点是一点嘛

@88250
Copy link
Member

88250 commented Dec 22, 2023

解析可能会有问题,漏了的话相当于引入新 bug 😂

@choyy
Copy link
Author

choyy commented Dec 22, 2023

这还会引发新bug吗?😂
按我的理解就是把sql里content like "%xxx%"中的关键词“xxx”给高亮出来,其他情况都不管了

@88250
Copy link
Member

88250 commented Dec 22, 2023

其他情况不管的话高亮不了就成 bug 了。

@choyy
Copy link
Author

choyy commented Dec 22, 2023

虽然这不够完美,但是其他少数情况暂时不考虑也不是不可以,应该不会有人发现(谁会在搜索面板写sql啊

@88250
Copy link
Member

88250 commented Dec 22, 2023

还是不弄了,就这样吧。

Vanessa219 added a commit that referenced this issue Dec 22, 2023

Verified

This commit was signed with the committer’s verified signature.
Vanessa219 added a commit that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants