Skip to content

Improve //!js query embed block result sorting #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frostime opened this issue Dec 26, 2023 · 2 comments
Closed

Improve //!js query embed block result sorting #9977

frostime opened this issue Dec 26, 2023 · 2 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.12.0

Comments

@frostime
Copy link
Contributor

frostime commented Dec 26, 2023 •
edited by 88250
Loading

让 //!js 查询结果的顺序和 includeId 完全保持一致

In what scenarios do you need this feature?

我自己测试的时候发现，js 查询的结果似乎并不会保证和 //!js 代码块返回的 id list 顺序保持一致。

image

Describe the optimal solution

在 getEmbedBlock 函数最后加一个排序操作

siyuan/kernel/api/search.go

Line 199 in 171b915

func getEmbedBlock(c *gin.Context) {

根据 includeId 的顺序重新排列一下 block 的顺序

image

Describe the candidate solution

No response

Other information

No response
@88250 88250 self-assigned this Dec 26, 2023
@88250 88250 added this to the 2.12.0 milestone Dec 26, 2023
@88250 88250 changed the title 让 //!js 查询结果的顺序和 includeId 完全保持一致 Improve //!js query embed block result sorting Dec 26, 2023
88250 added a commit that referenced this issue Dec 26, 2023
@88250
🎨 Improve //!js query embed block result sorting #9977

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
679870b
@88250
Copy link
Member

88250 commented Dec 26, 2023

等发 dev 版后请帮忙测试，谢谢。

@88250 88250 closed this as completed Dec 26, 2023
@frostime
Copy link
Contributor Author

dev版本测试了一下，应该是没问题了 👍
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.12.0
Development

No branches or pull requests
2 participants
@88250 @frostime