Skip to content

Add database lineNumber field type #11008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 14, 2024

Conversation

silent-tan
Copy link
Contributor

@silent-tan silent-tan commented Apr 12, 2024

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

#10991 中讨论的,增加了 lineNumber 列类型。涉及到:

  • 增加列类型
  • header cell 的菜单交互
  • body cell 的渲染和交互
  • lineNumber 列的编辑菜单
  • lineNumber 不参与排序和过滤
  • 从其他类型切换到 lineNumber 时,如果该列存在排序和过滤,要从配置中删除该列的排序和过滤

其他行为同普通列

Sorry, something went wrong.

@github-actions github-actions bot changed the base branch from master to dev April 12, 2024 20:22
Copy link

Your PR was set to target master, PRs should be target dev
The base branch of this PR has been automatically changed to dev, please check that there are no merge conflicts

@silent-tan silent-tan mentioned this pull request Apr 12, 2024
4 tasks
Vanessa219 and others added 9 commits April 13, 2024 10:32

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@silent-tan
Copy link
Contributor Author

silent-tan commented Apr 13, 2024

和需求无关的我在 Review 最后都会做一次删除,tour 和 标记,只是为了方便拉代码进行 Review

@silent-tan silent-tan changed the title 🎨 add database lineNumber type draft: 🎨 add database lineNumber type Apr 13, 2024
88250 and others added 9 commits April 13, 2024 22:38

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
…into dev
@88250 88250 changed the title draft: 🎨 add database lineNumber type draft: 🎨 add database lineNumber field type Apr 14, 2024
@88250 88250 changed the title draft: 🎨 add database lineNumber field type Add database lineNumber field type Apr 14, 2024

Verified

This commit was signed with the committer’s verified signature.
@88250 88250 added this to the backlog milestone Apr 14, 2024
@88250
Copy link
Member

88250 commented Apr 14, 2024

这里能否隐藏?

image

@silent-tan
Copy link
Contributor Author

silent-tan commented Apr 14, 2024

这里能否隐藏?

image

done, .tour 和 相关 todo tag 也移除了

@88250
Copy link
Member

88250 commented Apr 14, 2024

非常感谢,我合并 dev 了。

@88250 88250 merged commit 8a354da into siyuan-note:dev Apr 14, 2024
@88250 88250 modified the milestones: backlog, 3.0.10 Apr 14, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Apr 15, 2024

@Vanessa219 行号列的图标感觉有点丑,能换成长得像 No. 这样的图标吗?

@mozhux
Copy link

mozhux commented Apr 16, 2024

希望后续能把行号优化到第一列的选中那,鼠标未经过时显示行号,经过了就变成勾选框,类似WPS

@88250
Copy link
Member

88250 commented Apr 16, 2024

@mozhux 行号单独一列方便调整位置。

@88250
Copy link
Member

88250 commented Apr 16, 2024

@TCOTC 换成有序列表的图标了。

@mozhux
Copy link

mozhux commented Apr 16, 2024

@mozhux 行号单独一列方便调整位置。
从操作来看,两种方式的操作步骤一模一样,移动调整位置与行号无关,都是外面那六个点的操作,反而还多了一列占空间。

@88250
Copy link
Member

88250 commented Apr 16, 2024

我指的是行号这一列可以调整位置,比如放在最后或者中间。

@mozhux
Copy link

mozhux commented Apr 16, 2024

我指的是行号这一列可以调整位置,比如放在最后或者中间。

那这个确实无法反驳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants