Allow users to specify abcjsParams #11162
Merged
+28
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the parameters for abcjs are hard-coded to:
This prohibits the user from using other options, such as tablature.
For example, if I want to render this violin tab in the abcjs documentation, I cannot do it because there is no way to set the abcjsParams to:
This PR allows users to manually specify
abcjsParams
to use by prefixing the content with:Using this, the example now renders correctly:
Produces:

Please let me know if there is another approach to get the
abcjsParams
passed into the render function that you would prefer.EDIT: Updated the code to use the new format