Skip to content

Improve /menu #12547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Improve /menu #12547

merged 12 commits into from
Sep 23, 2024

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Sep 22, 2024

  1. 调整了一下 Add data-id attribute to the button of the block menu #12525
  2. 跟其他菜单保持统一,将 / 菜单中的分隔线元素改为 button
  3. 每个 button 添加 data-id ,关联 给常用菜单的 button 添加 data-id 属性 #12518
  4. 选项右侧优先显示快捷键,其次显示键盘输入

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
…v-menu-id
@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 22, 2024

可以 Review 了

@88250 88250 requested a review from Vanessa219 September 22, 2024 08:07
@TCOTC TCOTC changed the title 改进 / 菜单 Improve /menu Sep 22, 2024
value: "###### " + Lute.Caret,
html: `<div class="b3-list-item__first"><svg class="b3-list-item__graphic"><use xlink:href="#iconH6"></use></svg><span class="b3-list-item__text">${window.siyuan.languages.heading6}</span><span class="b3-menu__accelerator">${updateHotkeyTip((window.siyuan.config.keymap.editor.heading.heading6.custom))}</span></div>`,
html: `<div class="b3-list-item__first"><svg class="b3-list-item__graphic"><use xlink:href="#iconH6"></use></svg><span class="b3-list-item__text">${window.siyuan.languages.heading6}</span><span class="b3-menu__accelerator">${window.siyuan.config.keymap.editor.heading.heading6.custom ? `<span class="b3-menu__accelerator">${updateHotkeyTip((window.siyuan.config.keymap.editor.heading.heading6.custom))}</span>` : '<span class="b3-list-item__meta">&num;&num;&num;&num;&num;&num;&nbsp;</span>'}</div>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b3-menu__accelerator 是不是嵌套了?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实

Verified

This commit was signed with the committer’s verified signature.
@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 22, 2024

改好了

Verified

This commit was signed with the committer’s verified signature.
@Vanessa219 Vanessa219 merged commit 0885805 into siyuan-note:dev Sep 23, 2024
@Vanessa219 Vanessa219 added this to the 3.1.7 milestone Sep 23, 2024
Vanessa219 added a commit that referenced this pull request Sep 23, 2024

Verified

This commit was signed with the committer’s verified signature.
@TCOTC TCOTC deleted the dev-menu-id branch September 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants