Skip to content

Improve tooltip #13966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 26, 2025
Merged

Improve tooltip #13966

merged 12 commits into from
Feb 26, 2025

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Jan 29, 2025


关联 #13476

@TCOTC TCOTC mentioned this pull request Jan 29, 2025
@TCOTC TCOTC marked this pull request as draft January 30, 2025 05:40
@TCOTC TCOTC force-pushed the dev-tooltip-2 branch 3 times, most recently from 5d88bec to 6a4a250 Compare January 30, 2025 20:48
@TCOTC TCOTC marked this pull request as ready for review January 30, 2025 20:53
@88250 88250 requested a review from Vanessa219 February 8, 2025 01:39
@Vanessa219 Vanessa219 merged commit 0b4cff9 into siyuan-note:dev Feb 26, 2025
1 check passed
@Vanessa219 Vanessa219 added this to the 3.1.24 milestone Feb 26, 2025
@Vanessa219 Vanessa219 self-assigned this Feb 26, 2025
Vanessa219 added a commit that referenced this pull request Feb 26, 2025
@Vanessa219
Copy link
Member

改动有点多,还麻烦再看看。

@TCOTC TCOTC deleted the dev-tooltip-2 branch February 27, 2025 05:23
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 27, 2025

01

悬浮提示和元素之间没有间隔 1px

02

这个用于在拖拽笔记本后重新显示悬浮提示:

image

03

data-position 修改之后影响了插件,需要处理一下类似的情况(悬浮提示不能在鼠标下方弹出)

切换主题 插件的顶栏按钮:

video.webm

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 27, 2025

另外,用东南西北感觉很不直观,要不统一改成上下左右?

这样感觉好点:

image

Vanessa219 added a commit that referenced this pull request Feb 27, 2025
@Vanessa219
Copy link
Member

  1. 现在还会抖动么?有间距的话有些 tip 出现滚动条,是需要移动上去的进行滚动查看的
  2. 什么情况下没有 ariaLabel?
  3. 已修复
    和 b3-tooltips 保持用东南西北

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 27, 2025

01

在(Windows系统)默认主题下用这个代码片段再试试:

.tooltip {
    animation-name: unset;
}

我这里的情况是大部分时候试不出问题,但偶尔就能频繁触发:

VID202502280055081.mp4

02

笔记本:

image

Vanessa219 added a commit that referenced this pull request Feb 28, 2025
Vanessa219 added a commit that referenced this pull request Feb 28, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 28, 2025

02 可以了, 01 还没好 我再试试刚刚更新的

@Vanessa219
Copy link
Member

刚提交了

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 28, 2025

也不行,还是会闪烁

@Vanessa219
Copy link
Member

@88250 看一下 Windows 下是否闪烁?

@88250
Copy link
Member

88250 commented Feb 28, 2025

我这里正常

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 28, 2025

有用上面的 CSS 吗?

@88250
Copy link
Member

88250 commented Feb 28, 2025

用了的,我这里不会闪。

我觉得这个问题有点像之前你提过的一个,就是这种框框鼠标移过边缘会闪烁。

image

但我这里怎么整都重现不了。

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 28, 2025

我这里的情况就是在一段时间内很容易重现,一段时间内完全不能重现。不知道是什么问题

@88250
Copy link
Member

88250 commented Feb 28, 2025

可能是系统的原因

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants