Skip to content

Open the Explorer window in the foreground #14828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented May 15, 2025

fix #12652

  • openPath 是随便命名的,也许不合适
  • 也许把 shell.openPath 合并到 siyuan-open-folder 更好

如果要合并的话先说一下,我想用这个 PR 顺便更新一下设置里的这段话:“思源笔记已累计发版 661 次,解决用户需求与反馈 11877 次,提交代码 14796 次”

@88250
Copy link
Member

88250 commented May 15, 2025

如果要合并的话先说一下,我想用这个 PR 顺便更新一下设置里的这段话:“思源笔记已累计发版 661 次,解决用户需求与反馈 11877 次,提交代码 14796 次”

单独提交吧,谢谢。

@Vanessa219
Copy link
Member

#12652 看上去是要使用 showItemInFolder 来替代 openPath,但是这个PR看上去只是把 shell.openPath 移动了一下位置。

@TCOTC
Copy link
Contributor Author

TCOTC commented May 19, 2025

#12652 看上去是要使用 showItemInFolder 来替代 openPath

当时我应该没有实际试过,我现在测试的时候发现把 shell.openPath 直接改成 shell.showItemInFolder 也是不行的。是要换个位置才能解决

@Vanessa219
Copy link
Member

有开多个窗口或设置过窗口置顶什么的么?貌似没人有这个问题。

@TCOTC
Copy link
Contributor Author

TCOTC commented May 19, 2025

当时我在群里问了,有人回复也是这样:#12652 (comment) (这条回复我隐藏了,手动展开)

@Vanessa219
Copy link
Member

看一下 openExternal 也有这个问题么?

image

但是官网说都可以用的

image

@TCOTC
Copy link
Contributor Author

TCOTC commented May 22, 2025

“打开浏览器”这个按钮没有问题,打开的浏览器会在前台。我估计只有 Windwos 资源管理器有这个问题

@Vanessa219 Vanessa219 self-requested a review May 22, 2025 04:10
@Vanessa219 Vanessa219 added this to the 3.1.31 milestone May 22, 2025
@Vanessa219 Vanessa219 merged commit bf08509 into siyuan-note:dev May 22, 2025
4 checks passed
Vanessa219 added a commit that referenced this pull request May 22, 2025
@TCOTC TCOTC deleted the fix/12652 branch May 22, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants