Skip to content

开启 始终定位打开的文档 后再次选中文档页签时不再定位 #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

开启 始终定位打开的文档 后再次选中文档页签时不再定位 #6820

merged 1 commit into from
Dec 8, 2022

Conversation

meteor199
Copy link
Contributor

  • Please commit to the dev branch 请提交到 dev 开发分支
  • For contributing new features, please supplement and improve the corresponding user guide documents 对于贡献新特性,请补充完善对应用户指南文档
  • For bug fixes, please describe the problem and solution via code comments 对于修复缺陷,请通过代码注释描述问题和解决方案
  • For text improvements (such as typos and wording adjustments), please submit directly 对于文案改进(比如错别字措辞调整)请直接提交

已选中的文件再次选中时,不会在文件树中跳转

问题:

  1. 在文件树中,选中一个文件后,文件树会自动滚动,与常用的用户习惯不一样(在文件树中操作时,文件树不应滚动,便于用户对文件树进行其他操作)
  2. 选中一个文件后,手动滚动文件树,在Tab中点击文件,文件树也会自动滚动;可以参照vscode,已选中的文件再次选中后,不应滚动文件树。
    动画

重现方法:

  1. 设置>文档树,开启【适中定位打开的文档】
  2. 点击文档树中的文件(选择在可视区域内的文件),文档树进行自动滚动,将点击的文件居中。

修改方法:

  1. 已选中的文件再次选中时,禁止在文件树中跳转

Sorry, something went wrong.

@Vanessa219 Vanessa219 merged commit 2e15fbf into siyuan-note:dev Dec 8, 2022
@Vanessa219 Vanessa219 self-assigned this Dec 8, 2022
@Vanessa219 Vanessa219 self-requested a review December 8, 2022 13:41
@Vanessa219 Vanessa219 assigned meteor199 and unassigned Vanessa219 Dec 8, 2022
@Vanessa219 Vanessa219 added this to the 2.5.4 milestone Dec 8, 2022
@Vanessa219 Vanessa219 self-assigned this Dec 8, 2022
Vanessa219 added a commit that referenced this pull request Dec 8, 2022
@88250 88250 changed the title 🎨 已选中的文件再次选中时,禁止在文件树中跳转 开启 始终定位打开的文档 后已选中的文档再次选中时不在文档树中定位 Dec 8, 2022
@88250 88250 changed the title 开启 始终定位打开的文档 后已选中的文档再次选中时不在文档树中定位 开启 始终定位打开的文档 后再次选中文档页签时不再定位 Dec 8, 2022
@meteor199 meteor199 deleted the modify-file-tree-select branch December 9, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants