Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json 构建前端使用正则表达式 #7329

Merged
merged 1 commit into from Feb 11, 2023
Merged

package.json 构建前端使用正则表达式 #7329

merged 1 commit into from Feb 11, 2023

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Feb 10, 2023

As of pnpm 7.27.0, it supports script selector with RegExp.

See https://github.com/pnpm/pnpm/releases/tag/v7.27.0

@88250 88250 added the Refactor label Feb 11, 2023
@88250 88250 added this to the 2.7.5 milestone Feb 11, 2023
@88250 88250 changed the title chore: use regex script in package.json package.json 构建前端使用正则表达式 Feb 11, 2023
@88250
Copy link
Member

88250 commented Feb 11, 2023 •
edited

I tested it locally (Windows 11) according to your modification, and running pnpm run build will report an error:

...
...
external "electron" 42 bytes [built] [code generated]
external "path" 42 bytes [built] [code generated]
external "fs" 42 bytes [built] [code generated]
webpack 5.73.0 compiled successfully in 27981 ms
 ERR_PNPM_NO_SCRIPT  Missing script: /build:.*/
 ELIFECYCLE  Command failed with exit code 1.

@88250
Copy link
Member

88250 commented Feb 11, 2023

After executing pnpm install everything works fine.

@88250 88250 merged commit 1e71264 into siyuan-note:dev Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@kecrily kecrily

Labels
Refactor
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kecrily @88250