Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a potential null object reference in the electron main process #7956

Merged
merged 1 commit into from Apr 12, 2023
Merged

Fix a potential null object reference in the electron main process #7956

merged 1 commit into from Apr 12, 2023

Conversation

Soltus
Copy link
Contributor

@Soltus Soltus commented Apr 11, 2023

event.sender may be undefined that will raise a javascript error occurred in the main process

@Soltus Soltus mentioned this pull request Apr 11, 2023
Closed
@88250 88250 changed the title fix a potential null object reference in the electron main process Fix a potential null object reference in the electron main process Apr 12, 2023
@88250 88250 self-requested a review April 12, 2023 00:40
@88250 88250 added this to the 2.8.5 milestone Apr 12, 2023
@88250 88250 merged commit ab5bfe2 into siyuan-note:dev Apr 12, 2023
2 checks passed
@Soltus Soltus deleted the Soltus-patch-1 branch April 12, 2023 10:14
@88250 88250 mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@88250 88250 Awaiting requested review from 88250

Assignees

@Soltus Soltus

Labels
Bug
Projects
None yet
Milestone
2.8.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Soltus @88250