Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Petal module #8001

Merged
merged 3 commits into from Apr 18, 2023
Merged

Import Petal module #8001

merged 3 commits into from Apr 18, 2023

Conversation

zuoez02
Copy link
Contributor

@zuoez02 zuoez02 commented Apr 14, 2023 •
edited by 88250

  • Please commit to the dev branch 请提交到 dev 开发分支
  • For contributing new features, please supplement and improve the corresponding user guide documents 对于贡献新特性，请补充完善对应用户指南文档
  • For bug fixes, please describe the problem and solution via code comments 对于修复缺陷，请通过代码注释描述问题和解决方案
  • For text improvements (such as typos and wording adjustments), please submit directly 对于文案改进（比如错别字措辞调整）请直接提交

@zuoez02 zuoez02 changed the title Dev 集成petal(siyuan-plugin-system) Apr 14, 2023
@88250 88250 requested a review from Vanessa219 April 14, 2023 12:06
@88250 88250 changed the title 集成petal(siyuan-plugin-system) Import Petal module Apr 14, 2023
@88250 88250 added this to the 2.8.5 milestone Apr 14, 2023
@Vanessa219
Copy link
Member

不是要传 API 么？我是等等再合并么？

@zuoez02
Copy link
Contributor Author

zuoez02 commented Apr 14, 2023

不是要传 API 么？我是等等再合并么？

一步一步来？

@88250
Copy link
Member

88250 commented Apr 14, 2023

这里怕是要整个机制先跑通，然后再慢一点迭代。

这 PR 不一定就这个版本要合并，2.9 之前能合并就行。

@88250 88250 modified the milestones: 2.8.5, backlog, 2.8.6 Apr 14, 2023
@88250 88250 merged commit ed32996 into siyuan-note:dev Apr 18, 2023
88250 added a commit that referenced this pull request Apr 18, 2023
@88250
🎨 Import Petal module #8001
71ff3c6
@88250 88250 mentioned this pull request Apr 21, 2023
Closed
@88250 88250 modified the milestones: 2.8.6, 2.8.7 Apr 22, 2023
@88250
Copy link
Member

88250 commented Apr 22, 2023

入口的代码暂时回滚了，等下个版本再做从计议。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vanessa219 Vanessa219 Awaiting requested review from Vanessa219

Assignees

@zuoez02 zuoez02

Labels
Development
Projects
None yet
Milestone
2.8.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zuoez02 @Vanessa219 @88250