Kernel API /api/file/readDir support for returning symbolic link information
#8805
Conversation
|
Your PR was set to target |
| "name": entry.Name(), | ||
| "isDir": entry.IsDir(), | ||
| "name": entry.Name(), | ||
| "isDir": info.IsDir(), |
There was a problem hiding this comment.
| "isDir": info.IsDir(), | |
| "isDir": entry.IsDir(), |
Why change from entry.IsDir() to info.IsDir() ?
entry.IsDir() / dir.IsDir() (where entry and dir are of type fs.DirEntry) is being used in kernel/util/file.go > IsDirRegularOrSymlink too.
There was a problem hiding this comment.
// entry is a symlink to a dir
path := filepath.Join(dirPath, entry.Name())
info, err = os.Stat(path)
entry.IsDir() // return false
info.IsDir() // return true
There was a problem hiding this comment.
Guys, let's make sure the code here is ok:
There was a problem hiding this comment.
Oh, sorry, I missed the changes in file.go later, Zuoqiu has extracted a function IsSymlink(), it seems to be no problem.
There was a problem hiding this comment.
Guys, let's make sure the code here is ok:
If this function's name is IsDirRegularOrSymlink, it's Ok.
If this function's name is IsDirRegularOrDirSymlink, it's not Ok.👀
There was a problem hiding this comment.
@Zuoqiu-Yingyi Thanks for the explanation, I get it, merge first.
@fenilgmehta If there is something we missed, please continue to add comments, thank you.
88250
changed the title
/api/file/readDir support for returning symbolic link information/api/file/readDir support for returning symbolic link information
isDir: true, isSymlink: trueisDir: true, isSymlink: falseisDir: false, isSymlink: trueisDir: false, isSymlink: false