Support searching PDF asset content #8985
Merged
+125
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekrondev
commented
Aug 16, 2023
|
About the licensing issues discussed at #8874: go-pdfium is MIT, pdfium C++ library is Apache License v2 so it's compatible. |
88250
changed the title
88250
requested changes
Aug 16, 2023
88250
added a commit
that referenced
this pull request
Aug 17, 2023
88250
added a commit
that referenced
this pull request
Aug 17, 2023
88250
added a commit
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(asset): Add PDF parser based on go-pdfium WASM module
This change adds the webassembly-based pdfium module for parsing PDF files into text used by SiYuan asset search.
A test case checks parsing a multi-page Chinese PDF (GPL in Chinese language) if the text contents will be returned.
Note: Frontend changes are not included with this PR.