Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the style of disabled menu item #9078

Merged

Conversation

Zuoqiu-Yingyi
Copy link
Contributor

  • Please commit to the dev branch
  • For contributing new features, please supplement and improve the corresponding user guide documents
  • For bug fixes, please describe the problem and solution via code comments
  • For text improvements (such as typos and wording adjustments), please submit directly

修复被禁用的菜单项的下级菜单透明度叠加问题
Fixed the submenu transparency overlay issue for disabled menu items

@Vanessa219
Copy link
Member

被禁用的菜单含有子菜单,按逻辑应该不需要显示子菜单了。鼠标移上和右键也应该不被展开。

@Zuoqiu-Yingyi
Copy link
Contributor Author

被禁用的菜单含有子菜单,按逻辑应该不需要显示子菜单了。鼠标移上和右键也应该不被展开。

按照人机交互理念,被禁用的功能也应该显示出来以告知用户该功能的存在

@Vanessa219
Copy link
Member

但是这样就没办法阻止被禁用的子菜单中存在可以使用的项了。

@Zuoqiu-Yingyi
Copy link
Contributor Author

但是这样就没办法阻止被禁用的子菜单中存在可以使用的项了。

由开发者控制即可

@Vanessa219 Vanessa219 merged commit eb461fa into siyuan-note:dev Sep 1, 2023
@88250 88250 added this to the 2.10.3 milestone Sep 1, 2023
Vanessa219 added a commit that referenced this pull request Sep 1, 2023
@Vanessa219 Vanessa219 self-assigned this Sep 1, 2023
@Zuoqiu-Yingyi Zuoqiu-Yingyi deleted the feat/style-menu-item-disabled branch September 1, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants